-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix node e2e test #2991
fix node e2e test #2991
Conversation
Thanks for your contribution. 🍻 @zhuangqh |
Codecov Report
@@ Coverage Diff @@
## master #2991 +/- ##
==========================================
+ Coverage 66.74% 67.99% +1.25%
==========================================
Files 291 291
Lines 18655 18660 +5
==========================================
+ Hits 12451 12688 +237
+ Misses 4719 4488 -231
+ Partials 1485 1484 -1
|
ping @zhuangqh , I think we missing a patch here for nil panic issue. could you update the pr in time? Thanks
|
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: zhuangqh zhuangqhc@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews