Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrd: fix task unexpected exit #3002

Merged
merged 1 commit into from
Nov 25, 2019
Merged

ctrd: fix task unexpected exit #3002

merged 1 commit into from
Nov 25, 2019

Conversation

Ace-Tang
Copy link
Contributor

time="2019-11-01T09:54:30.981479019+08:00" level=info msg="the task has
quit, id:
e3954a23946f1415f3ed2f0010024536a119a3645bf4cdc884c04e33b725ae1e, err:
rpc error: code = Canceled desc = context canceled, exitcode: 255, time:
0001-01-01 00:00:00 +0000 UTC"
ContainerID=e3954a23946f1415f3ed2f0010024536a119a3645bf4cdc884c04e33b725ae1e

get task exit message, this caused by grpc server stop first, but pouch
still running, task will got this message

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

time="2019-11-01T09:54:30.981479019+08:00" level=info msg="the task has
quit, id:
e3954a23946f1415f3ed2f0010024536a119a3645bf4cdc884c04e33b725ae1e, err:
rpc error: code = Canceled desc = context canceled, exitcode: 255, time:
0001-01-01 00:00:00 +0000 UTC"
ContainerID=e3954a23946f1415f3ed2f0010024536a119a3645bf4cdc884c04e33b725ae1e

get task exit message, this caused by grpc server stop first, but pouch
still running, task will got this message

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #3002 into master will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3002      +/-   ##
==========================================
- Coverage   67.98%   67.91%   -0.08%     
==========================================
  Files         291      291              
  Lines       18687    18691       +4     
==========================================
- Hits        12705    12694      -11     
- Misses       4500     4512      +12     
- Partials     1482     1485       +3
Flag Coverage Δ
#criv1alpha2_test 34.55% <33.33%> (-0.03%) ⬇️
#integration_test_0 36.36% <33.33%> (-0.01%) ⬇️
#integration_test_1 35.94% <33.33%> (-0.05%) ⬇️
#integration_test_2 36.32% <33.33%> (+0.02%) ⬆️
#integration_test_3 35.82% <33.33%> (-0.06%) ⬇️
#node_e2e_test 34.02% <33.33%> (-0.01%) ⬇️
#unittest 26.63% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
daemon/daemon.go 67.82% <0%> (ø) ⬆️
ctrd/watch.go 70.37% <40%> (-7.56%) ⬇️
ctrd/supervisord/daemon.go 47.8% <0%> (-1.32%) ⬇️
cri/v1alpha2/cri.go 60.24% <0%> (-0.85%) ⬇️
daemon/mgr/container.go 60.09% <0%> (-0.6%) ⬇️
daemon/mgr/container_utils.go 77.18% <0%> (+0.97%) ⬆️
pkg/meta/store.go 65.89% <0%> (+3.1%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuangqh zhuangqh merged commit 39d06cc into master Nov 25, 2019
@fuweid fuweid deleted the fix-exit branch January 2, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants