feature: add port mapping for container #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add port mapping for container. You can use:
-p or --port to port binging into container
--expose to expose container's port to access.
pouch run -d -p 8888:80 registry.docker.com/library/nginx:latest
Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Letty5411
reviewed
Mar 7, 2018
| c.Assert(err, check.IsNil) | ||
|
|
||
| command.PouchRun("rm", "-f", funcname) | ||
| } |
|
CI failed due to know issue #815 |
|
@rudyfly could you also add test to check the exposed port works? |
Codecov Report
@@ Coverage Diff @@
## 0.2.x #833 +/- ##
==========================================
- Coverage 13.77% 13.62% -0.16%
==========================================
Files 107 107
Lines 6460 6534 +74
==========================================
Hits 890 890
- Misses 5511 5585 +74
Partials 59 59
Continue to review full report at Codecov.
|
allencloud
reviewed
Mar 8, 2018
| @@ -131,18 +135,61 @@ func (c *container) config() (*types.ContainerCreateConfig, error) { | |||
| } | |||
| } | |||
|
|
|||
| // parse port binding | |||
There was a problem hiding this comment.
In the future, we could encapsulate the following code block into a function like parsePortMapping
func parsePortMapping(ports []string)(ports [string]nats, portBindings xxxx)
maybe has the incorrect type, but the similar meaning. In addition, this is much easier to write unit test cases.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add port mapping for container. You can use:
-p or --port to port binging into container
--expose to expose container's port to access.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com