Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add inspect format for image network and volume #871

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

Letty5411
Copy link
Contributor

Ⅰ. Describe what this PR did

Add inspect format option for image/network/volume.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

#pouch network inspect -f {{.Name}} bridge
bridge

#pouch image inspect -f {{.Name}} docker.io/library/busybox:latest
docker.io/library/busybox:latest

Ⅴ. Special notes for reviews

Signed-off-by: letty <letty.ll@alibaba-inc.com>
@Letty5411 Letty5411 changed the title Inspect [feature] add inspect format for image network and volume Mar 12, 2018
@Letty5411
Copy link
Contributor Author

CI failed due to issue #815 , not relate to this PR.

@codecov-io
Copy link

Codecov Report

Merging #871 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #871      +/-   ##
=========================================
+ Coverage   14.89%   14.9%   +<.01%     
=========================================
  Files         114     114              
  Lines        6826    6825       -1     
=========================================
  Hits         1017    1017              
+ Misses       5723    5722       -1     
  Partials       86      86
Impacted Files Coverage Δ
cli/image_inspect.go 0% <0%> (ø) ⬆️
cli/network.go 0% <0%> (ø) ⬆️
cli/volume.go 9.43% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1564d7a...5d13f60. Read the comment docs.

@HusterWan
Copy link
Contributor

LGTM

@HusterWan HusterWan merged commit 28ad3a5 into AliyunContainerService:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants