Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linting] Fix go misspell linting errors #990

Merged
merged 1 commit into from
Mar 28, 2018
Merged

[linting] Fix go misspell linting errors #990

merged 1 commit into from
Mar 28, 2018

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented Mar 28, 2018

Ⅰ. Describe what this PR did

This PR is to address the go misspell linting issues raised in the Go Report Card to partially address issue #964. See https://goreportcard.com/report/github.com/alibaba/pouch

Ⅱ. Does this pull request fix one issue?

This PR partially fixes issue #964.

Ⅲ. Describe how you did it

Corrected misspell errors reported in Go Report Card.

Ⅳ. Describe how to verify it

All misspell errors should be gone from Go Report Card.

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Mar 28, 2018
@pouchrobot
Copy link
Collaborator

@bvwells Thanks for your contribution. 🍻
Please sign off in each of your commits.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @bvwells
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@allencloud
Copy link
Collaborator

Thanks a lot for your work. @bvwells
Look much better after your code change.
LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 28, 2018
@pouchrobot
Copy link
Collaborator

ping @bvwells

CI fails according integration system.
Please refer to the CI failure Details button to corresponding test, and update your PR to pass CI.

If this is flaky test, welcome to track this with profiling an issue.

build url: https://travis-ci.org/alibaba/pouch/builds/359424737
build duration: 1142s

@allencloud
Copy link
Collaborator

I am afraid that CI fails with:

FAIL: /go/src/github.com/alibaba/pouch/test/api_restart_test.go:25: APIContainerRestartSuite.TestAPIContainerRestart
/go/src/github.com/alibaba/pouch/test/api_restart_test.go:40:
    CheckRespStatus(c, resp, 204)
/go/src/github.com/alibaba/pouch/test/util_api.go:21:
    c.Assert(resp.StatusCode, check.Equals, status, check.Commentf("Error:%s", got.Message))
... obtained int = 500
... expected int = 204
... Error:container: : too many
----------------------------------------------------------------------
FAIL: /go/src/github.com/alibaba/pouch/test/api_restart_test.go:46: APIContainerRestartSuite.TestAPIRestartStoppedContainer
/go/src/github.com/alibaba/pouch/test/api_restart_test.go:49:
    CreateBusyboxContainerOk(c, cname)
/go/src/github.com/alibaba/pouch/test/util_api.go:21:
    c.Assert(resp.StatusCode, check.Equals, status, check.Commentf("Error:%s", got.Message))
... obtained int = 409
... expected int = 201
... Error:container name: TestAPIContainerRestart: already existed

This error is also seen from PR #988 's CI.

I have to say this is unrelated to the code change this PR brought.

Merging...

@allencloud allencloud merged commit e759583 into AliyunContainerService:master Mar 28, 2018
@bvwells
Copy link
Contributor Author

bvwells commented Mar 28, 2018

Thanks @allencloud for the quick review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants