Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: create config file for reservation preferences #54

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

Alkaar
Copy link
Owner

@Alkaar Alkaar commented Oct 11, 2022

Move the config file for the reservations to be an actual config file that is separate from the code implementation. This provides a better separation of concerns as well as allows better configurability if you wanted to create multiple config files for different restaurant reservations.

  • Added pureconfig to allow converting a config file to a case class
  • Created config file
  • Necessary refactorings

@Alkaar Alkaar added breaking Major change, breaking API feat A new feature labels Oct 11, 2022
@Alkaar Alkaar self-assigned this Oct 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 55.28% // Head: 58.62% // Increases project coverage by +3.33% 🎉

Coverage data is based on head (72f69f3) compared to base (4b8f0f3).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   55.28%   58.62%   +3.33%     
==========================================
  Files           5        5              
  Lines         123      116       -7     
  Branches        1        2       +1     
==========================================
  Hits           68       68              
+ Misses         55       48       -7     
Impacted Files Coverage Δ
src/main/scala/com/resy/ResyBookingBot.scala 0.00% <0.00%> (-6.25%) ⬇️
src/main/scala/com/resy/ResyConfig.scala 100.00% <100.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Alkaar Alkaar merged commit 75777f5 into master Oct 12, 2022
@Alkaar Alkaar deleted the feat/create-config-file-for-res-preferences branch October 12, 2022 14:05
@github-actions
Copy link

🚀 PR was released in v3.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Major change, breaking API feat A new feature released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants