Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle assembleRelease fails #51

Closed
mimi89999 opened this issue Apr 18, 2020 · 5 comments · Fixed by #52
Closed

gradle assembleRelease fails #51

mimi89999 opened this issue Apr 18, 2020 · 5 comments · Fixed by #52

Comments

@mimi89999
Copy link

michel@debian:~/git/EasyRSS$ ./gradlew assembleRelease
Starting a Gradle Daemon (subsequent builds will be faster)
warn: removing resource org.freshrss.easyrss:string/TxtShareWithNote without required default value.


> Task :app:compileReleaseJavaWithJavac
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :app:lintVitalRelease
/home/michel/git/EasyRSS/app/src/main/res/layout/settings.xml:345: Error: Duplicate id @+id/TitleName, already defined earlier in this layout [DuplicateIds]
                        android:id="@+id/TitleName"
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/michel/git/EasyRSS/app/src/main/res/layout/settings.xml:65: Duplicate id @+id/TitleName originally defined here
/home/michel/git/EasyRSS/app/src/main/res/layout/settings.xml:472: Error: Duplicate id @+id/TitleName, already defined earlier in this layout [DuplicateIds]
                        android:id="@+id/TitleName"
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/michel/git/EasyRSS/app/src/main/res/layout/settings.xml:65: Duplicate id @+id/TitleName originally defined here
/home/michel/git/EasyRSS/app/src/main/res/layout/settings.xml:527: Error: Duplicate id @+id/SettingSyncStatus, already defined earlier in this layout [DuplicateIds]
                        android:id="@+id/SettingSyncStatus"
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/michel/git/EasyRSS/app/src/main/res/layout/settings.xml:120: Duplicate id @+id/SettingSyncStatus originally defined here
/home/michel/git/EasyRSS/app/src/main/res/layout/settings.xml:792: Error: Duplicate id @+id/TitleName, already defined earlier in this layout [DuplicateIds]
                        android:id="@+id/TitleName"
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/michel/git/EasyRSS/app/src/main/res/layout/settings.xml:65: Duplicate id @+id/TitleName originally defined here
/home/michel/git/EasyRSS/app/src/main/res/layout/single_item_view.xml:161: Error: Duplicate id @+id/BtnText, already defined earlier in this layout [DuplicateIds]
                        android:id="@+id/BtnText"
                        ~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/michel/git/EasyRSS/app/src/main/res/layout/single_item_view.xml:127: Duplicate id @+id/BtnText originally defined here

   Explanation for issues of type "DuplicateIds":
   Within a layout, id's should be unique since otherwise findViewById() can
   return an unexpected view.

/home/michel/git/EasyRSS/app/src/main/res/values-zh-rCN/strings.xml:44: Error: "TxtShareWithNote" is translated here but not found in default locale [ExtraTranslation]
    <string name="TxtShareWithNote">分享并添加笔记</string>
            ~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "ExtraTranslation":
   If a string appears in a specific language translation file, but there is
   no corresponding string in the default locale, then this string is probably
   unused. (It's technically possible that your application is only intended
   to run in a specific locale, but it's still a good idea to provide a
   fallback.)

   Note that these strings can lead to crashes if the string is looked up on
   any locale not providing a translation, so it's important to clean them
   up.

6 errors, 0 warnings

> Task :app:lintVitalRelease FAILED

FAILURE: Build failed with an exception.

It is also possible to disable checking of release build with checkReleaseBuilds false.

Alkarex added a commit that referenced this issue Apr 18, 2020
#Fix #51
@Alkarex Alkarex mentioned this issue Apr 18, 2020
Merged
@Alkarex
Copy link
Owner

Alkarex commented Apr 18, 2020

Thanks @mimi89999 I am not sure why those are errors and not just warnings. I do not know why those IDs were duplicated to start with, but should be fixed with #52

@Alkarex
Copy link
Owner

Alkarex commented Apr 18, 2020

@mimi89999 Should I issue a new release for testing again that is passes?

@mimi89999
Copy link
Author

Yes, please. When you will merge #52 and (possibly) make other changes please test if ./gradlew assembleRelease succeeds and if it does, please make a new release and update https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6628.

@Alkarex
Copy link
Owner

Alkarex commented Apr 19, 2020

gradlew assembleRelease

> Task :app:compileReleaseJavaWithJavac
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

BUILD SUCCESSFUL in 6s
24 actionable tasks: 8 executed, 16 up-to-date

Alkarex added a commit that referenced this issue Apr 19, 2020
* Lint

#Fix #51

* One more duplicated ID
@Alkarex
Copy link
Owner

Alkarex commented Apr 19, 2020

eighthave pushed a commit to f-droid/fdroiddata that referenced this issue Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants