[eval] increase timeout for SWEBench eval init/complete #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I just hit this. Thanks for the fix! |
|
Actually - i think this goes further into #3653 - we probably also need to change the client-side code for this. Setting this timeout was actually not honored by runtime client.. |
enyst
reviewed
Sep 11, 2024
tests/integration/mock/eventstream_runtime/DelegatorAgent/test_edits/prompt_002.log
Outdated
Show resolved
Hide resolved
enyst
reviewed
Sep 11, 2024
.../integration/mock/eventstream_runtime/DelegatorAgent/test_write_simple_script/prompt_005.log
Outdated
Show resolved
Hide resolved
xingyaoww
force-pushed
the
xw/increase-timeout-eval
branch
from
bf551d3
to
61ccecf
Compare
|
This should be finally ready for another review :) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG
Sometimes it takes a little while to run
git reset --hardthan the default timeout. Without a longer timeout, the runtime would return too early and causingassert exit_code == 0to fail.Could fix #3834
Give a summary of what the PR does, explaining any non-trivial design decisions
Link of any specific issues this addresses