Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all actions in the message window #5190

Merged
merged 38 commits into from
Dec 3, 2024
Merged

Show all actions in the message window #5190

merged 38 commits into from
Dec 3, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Nov 21, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    CHANGELOG: A message is shown every time the agent runs a command

Give a summary of what the PR does, explaining any non-trivial design decisions

This shows a chat message every time the agent takes an action, including running commands, python, and reading and writing files (the latter two don't really seem to happen--I think the agent always uses python)

Details are hidden by default but can be shown with a click.

At first the message says e.g. "running a bash command", but changes to "ran a bash command" once the output is observed

Screenshot 2024-11-21 at 4 13 06 PM

Nov-21-2024 16-11-37


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:44b7673-nikolaik   --name openhands-app-44b7673   docker.all-hands.dev/all-hands-ai/openhands:44b7673

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about all the details here, but I do think we should do this. Thank you for taking a stab at it!

You may want some @amanape eyes on it when it gets closer.

@neubig neubig force-pushed the rb/action-messages branch 2 times, most recently from cff42da to 981a7d1 Compare December 1, 2024 21:28
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had OpenHands fix the merge errors and failing tests, and ran it myself. It seems to be working and it's quite nice!

I'm happy to have this in but it'd be nice for @amanape and @rbren to take a final look.

@neubig neubig requested a review from amanape December 1, 2024 22:47
@rbren rbren marked this pull request as ready for review December 3, 2024 17:26
@rbren rbren merged commit 793e142 into main Dec 3, 2024
13 checks passed
@rbren rbren deleted the rb/action-messages branch December 3, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants