Microagent to fix issues with npm #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
approved these changes
Nov 28, 2024
tobitege
reviewed
Nov 28, 2024
| --- | ||
|
|
||
| When using npm to install packages, you will not be able to use an interactive shell, and it may be hard to confirm your actions. | ||
| As an alternative, you can pipe in the output of the unix "yes" command to confirm your actions. |
There was a problem hiding this comment.
npm could just be called with "-y" flag, iirc
There was a problem hiding this comment.
Thanks! It can be, but that doesn't work when we use things like "create-vite" (as I briefly mentioned in the original PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
When using
npm, it confirms on the command line if we'd like to install packages, which results in a timeout.This PR encourages the agent to auto-confirm these changes.
Note that I also tried adding the
--yescommand line argument to npm, but that doesn't work for things like thecreate-vitecommand, which is not confirmed by just adding--yes.To run this PR locally, use the following command: