Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align docstrings with Google style #5328

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

young010101
Copy link
Contributor

  • Use backticks for code references in docstrings
  • Fix typo in "compatibility"
  • Ensure docstring format follows Google style guide

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses

- Use backticks for code references in docstrings
- Fix typo in "compatibility"
- Ensure docstring format follows Google style guide
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! We are not including types in docstrings, as they are already included in the type annotations provided in the functions. So could you please revert that change? The other change is good and I'm happy to accept that!

@young010101
Copy link
Contributor Author

Hello! We are not including types in docstrings, as they are already included in the type annotations provided in the functions. So could you please revert that change? The other change is good and I'm happy to accept that!

Got it! I'll revert the change regarding types in the docstrings and keep the other update. Thx for clarifying!

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@neubig neubig merged commit 05cc6d4 into All-Hands-AI:main Dec 3, 2024
12 checks passed
@young010101 young010101 deleted the docs/align-with-google-style branch December 3, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants