Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5337: [Bug]: lint-fix workflow is failing frontend and python steps #5338

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

openhands-agent
Copy link
Contributor

@openhands-agent openhands-agent commented Nov 30, 2024

This pull request fixes #5337.

The PR successfully addresses both issues identified in the bug report:

  1. For the frontend linting inconsistency: The AI confirmed that both the regular lint workflow (npm run lint) and the fix workflow (npm run lint:fix) use the same underlying eslint and prettier commands, with the only difference being the addition of the --fix flag for the fix workflow. This ensures consistency between the checking and fixing processes.

  2. For the Python step dependency issue: The AI restructured the workflow by splitting the single lint-fix job into two independent jobs (lint-fix-frontend and lint-fix-python). This architectural change means that both linting processes will run independently, and a failure in the frontend linting will no longer prevent the Python linting from executing.

The changes maintain the existing permissions and conditions while improving the workflow's reliability and clarity with separate commit messages for each type of fix. This solution can be recommended for review as it directly addresses both reported issues without introducing new complications.

Automatic fix generated by OpenHands 🙌


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:a455154-nikolaik   --name openhands-app-a455154   docker.all-hands.dev/all-hands-ai/openhands:a455154

@enyst enyst added the lint-fix Attempts to fix lint issues on the PR label Nov 30, 2024
@mamoodi mamoodi requested a review from enyst November 30, 2024 22:18
@enyst enyst marked this pull request as ready for review November 30, 2024 23:59
@enyst enyst requested a review from neubig December 1, 2024 00:03
@neubig neubig merged commit 6ee9028 into main Dec 1, 2024
14 checks passed
@neubig neubig deleted the openhands-fix-issue-5337 branch December 1, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint-fix Attempts to fix lint issues on the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: lint-fix workflow is failing frontend and python steps
3 participants