issue/4599-Add cursor position information on the bottom of the editor area #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h will be changed dynamically.
|
This PR is renewable version of the previous PR 4626 which had been admitted by maintainers while there was some conflicts when some new changes were added into the project. |
|
@amanape has this on his list to take a look. |
|
Just need to take care of those linting errors and we're all set to merge |
|
I've solved linting errors by adapting my code to a prettier style ~ |
|
I may revert this PR because the display makes the file a little hard to see. And I want to get a release out. |
|
All right, I'll try to fix it soon~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR add information of where the cursor is inside the editor area. The information goes like:
Here's the implementation:
I've made this change by only modifying
Added a variable cursorPosition to record the position of the cursor.
Dynamically change cursorPosition in handleEditorDidMount and pass it as a parameter to the sub-component code-editor-component.
Add the cursorPosition member variable to the component definition.
Add a div element to the return statement to display the cursorPosition information.
Link of any specific issues this addresses、
source issue issue#4599