[Evaluation]: Log openhands version in eval output folder, instead of agent version #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
reviewed
Dec 4, 2024
neubig
reviewed
Dec 4, 2024
enyst
approved these changes
Dec 4, 2024
neubig
reviewed
Dec 4, 2024
Comment on lines
37
to
39
| # IMPORTANT: Because Agent's prompt changes fairly often in the rapidly evolving codebase of OpenHands | ||
| # We need to track the version of Agent in the evaluation to make sure results are comparable | ||
| AGENT_VERSION=v$(poetry run python -c "import openhands.agenthub; from openhands.controller.agent import Agent; print(Agent.get_cls('$AGENT').VERSION)") | ||
| OPENHANDS_VERSION=v$(poetry run python -c "import openhands.agenthub; from openhands.controller.agent import Agent; print(Agent.get_cls('$AGENT').VERSION)") |
There was a problem hiding this comment.
Delete this in favor of get_openhands_version?
There was a problem hiding this comment.
Good catch! Deleted in the latest commit.
neubig
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
There's a lot of things that could impact agent quality since the start of this project - e.g, reliability of bash terminal, better implementation of memory condensation, etc. So I think it probably make sense to track these eval runs by OpenHands version, instead of agent version.
Link of any specific issues this addresses
To run this PR locally, use the following command: