Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize version from pyproject.toml #5412

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Dec 4, 2024

Prioritize version from pyproject.toml over importlib

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

When running directly from poetry, I get the following:

>>> from openhands import get_version
>>> get_version()
'0.0.0.post2755+c5117bc48'

Which leads to...
docker.errors.NotFound: 404 Client Error for http+docker://localhost/v1.47/containers/openhands-runtime-vvLDWakILRMQYcw_AAAB/json: Not Found ("No such container: openhands-runtime-vvLDWakILRMQYcw_AAAB")

This PR prioritizes the version from the pyproject.toml so that runtime images can be built.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:310ddce-nikolaik   --name openhands-app-310ddce   docker.all-hands.dev/all-hands-ai/openhands:310ddce

@tofarr tofarr marked this pull request as ready for review December 4, 2024 19:10
@enyst enyst requested a review from xingyaoww December 4, 2024 19:15
@enyst enyst merged commit ceb60b9 into main Dec 4, 2024
13 checks passed
@enyst enyst deleted the fix-prioritize-pyproject-version branch December 4, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants