Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2b take two #5433

Merged
merged 4 commits into from
Dec 6, 2024
Merged

e2b take two #5433

merged 4 commits into from
Dec 6, 2024

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Dec 6, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    Fix the resolver workflow.

Give a summary of what the PR does, explaining any non-trivial design decisions

E2B update take two:

  • poetry lock set to minimum 1.0.4 (the newest version is 1.0.5 since last night)
  • poetry lock set to minimum 1.0.5, the resolver will end up using 1.0.5 anyway with its dependency resolution😅

The resolver uses pip for dependency resolution, while we use poetry. That should work (it creates requirements.txt from poetry and uses some caching in the workflow)... except when it doesn't. 😅

Our poetry lock had (or had reverted to) 0.17.1, while the resolver was trying to work with 1.0.4 yesterday, 1.0.5 last night.


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:0d5a3fb-nikolaik   --name openhands-app-0d5a3fb   docker.all-hands.dev/all-hands-ai/openhands:0d5a3fb

Fix #5425

@enyst enyst requested review from xingyaoww and neubig December 6, 2024 15:43
@mamoodi mamoodi enabled auto-merge (squash) December 6, 2024 15:54
@mamoodi mamoodi merged commit f4ee3a4 into main Dec 6, 2024
13 checks passed
@mamoodi mamoodi deleted the enyst/e2b-lock branch December 6, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to import 'TimeoutException' from 'e2b.sandbox'
3 participants