Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to config defaults #6370

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Revert changes to config defaults #6370

merged 3 commits into from
Jan 21, 2025

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Jan 20, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

The default seems to have changed in a120872

@csmith49 any reason it changed? Are there any other defaults that changed in your PR?

Edit: found close_delay as well--probably a merge conflict


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:e546b2b-nikolaik   --name openhands-app-e546b2b   docker.all-hands.dev/all-hands-ai/openhands:e546b2b

@rbren rbren changed the title enable prompt extensions by default Revert changes to config defaults Jan 20, 2025
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@csmith49
Copy link
Collaborator

No defaults that changed deliberately, result of a merge conflict I think.

@enyst enyst merged commit 509892c into main Jan 21, 2025
14 checks passed
@enyst enyst deleted the rb/enable-prompt-ext branch January 21, 2025 03:23
zchn pushed a commit to zchn/OpenHands that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants