Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check to shutdown hook #6402

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Added check to shutdown hook #6402

merged 2 commits into from
Jan 21, 2025

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Jan 21, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:c4f8b3e-nikolaik   --name openhands-app-c4f8b3e   docker.all-hands.dev/all-hands-ai/openhands:c4f8b3e

@mamoodi
Copy link
Collaborator

mamoodi commented Jan 21, 2025

This PR seems to work as intended now!

@tofarr tofarr marked this pull request as ready for review January 21, 2025 22:09
@mamoodi mamoodi enabled auto-merge (squash) January 21, 2025 22:13
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 21, 2025

Fixes: #6382

@mamoodi mamoodi merged commit 318c811 into main Jan 21, 2025
14 checks passed
@mamoodi mamoodi deleted the fix-remove-runtimes branch January 21, 2025 22:32
zchn pushed a commit to zchn/OpenHands that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants