-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue where retries continue on a closed runtime #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
reviewed
Jan 31, 2025
rbren
reviewed
Jan 31, 2025
openhands/server/conversation_manager/standalone_conversation_manager.py
Outdated
Show resolved
Hide resolved
xingyaoww
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM and I just pushed a commit that add remote_runtime_enable_retries
to all eval scripts
zchn
pushed a commit
to zchn/OpenHands
that referenced
this pull request
Feb 4, 2025
…I#6564) Co-authored-by: Xingyao Wang <xingyao6@illinois.edu>
adityasoni9998
pushed a commit
to adityasoni9998/OpenHands
that referenced
this pull request
Feb 7, 2025
…I#6564) Co-authored-by: Xingyao Wang <xingyao6@illinois.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
This PR fixes an issue where retry attempts would continue even after a runtime was closed, which could lead to unnecessary resource usage and potential errors.
Give a summary of what the PR does, explaining any non-trivial design decisions
The PR makes the following changes:
_stop_if_closed
method to the RemoteRuntime class that checks if the runtime is closed_wait_until_alive
and_send_action_server_request
methodsKey changes:
self._stop_if_closed
to the stop conditions in retry decorators_cleanup_stale
method to include stack tracesThis change ensures that retry attempts are properly terminated when a runtime is closed, preventing unnecessary resource usage and potential errors from retrying operations on a closed runtime.
Link of any specific issues this addresses
N/A
To run this PR locally, use the following command: