-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Github Service #6580
Merged
Merged
Refactor: Github Service #6580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e req from settings fetching
enyst
reviewed
Feb 2, 2025
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
…/OpenHands into refactor/gh-service
tofarr
reviewed
Feb 3, 2025
tofarr
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰 - Just one question (Not a blocker)
zchn
pushed a commit
to zchn/OpenHands
that referenced
this pull request
Feb 4, 2025
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
adityasoni9998
pushed a commit
to adityasoni9998/OpenHands
that referenced
this pull request
Feb 7, 2025
Co-authored-by: Engel Nyst <enyst@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
The motivation for this PR is "separation of concerns" with respect to the
GithubService
classWe want to the
GithubService
toJSONResponses
for its callers. This is for reusability purposes. The caller of theGithubService
class should be responsible for handling the data and constructing theJSONResponses
if need beThis PR accomplishes these constraints by -
GithubTokenMiddleware
; token fetching for the user occurs insideGithubService
GithubService
JSONResponse
objects, rather than delegating that responsibility toGithubService
This achieves "separation of concerns", and better reusability because we can use
GithubService
in both HTTP and non-HTTP related settingsLink of any specific issues this addresses
To run this PR locally, use the following command: