Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(frontend): Only show settings error toast when there is an error #6587

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

amanape
Copy link
Member

@amanape amanape commented Feb 3, 2025

End-user friendly description of the problem this fixes or functionality that this introduces
Whenever GET /settings passes, a settings-specific error toast is show.

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
Only show when it actually errors


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:c0b9a74-nikolaik   --name openhands-app-c0b9a74   docker.all-hands.dev/all-hands-ai/openhands:c0b9a74

@amanape amanape self-assigned this Feb 3, 2025
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@amanape amanape merged commit 6d62be5 into main Feb 3, 2025
16 checks passed
@amanape amanape deleted the hotfix/settings-error-only-when-error branch February 3, 2025 14:29
zchn pushed a commit to zchn/OpenHands that referenced this pull request Feb 4, 2025
adityasoni9998 pushed a commit to adityasoni9998/OpenHands that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants