Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit SQL files #68

Closed
diwu-sf opened this issue Feb 13, 2025 · 0 comments · Fixed by #70
Closed

Cannot edit SQL files #68

diwu-sf opened this issue Feb 13, 2025 · 0 comments · Fixed by #70
Assignees
Labels
bug Something isn't working fix-me

Comments

@diwu-sf
Copy link

diwu-sf commented Feb 13, 2025

Getting error:

File validation failed for /workspace/tests/assert_top_customers_has_five_rows.sql: File type application/sql is not supported. Only text files can be edited.

I think the mime type validation is way too strict and is triggering on lots of file types that are text.

Proposal is NOT to use the mime type and instead just check if the file is binary or not, via a library like binaryornot.
If the file is NOT binary, then treat it as text and allow the edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-me
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants