Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strict mimetype validation #70

Merged
merged 3 commits into from
Feb 14, 2025
Merged

fix: strict mimetype validation #70

merged 3 commits into from
Feb 14, 2025

Conversation

ryanhoangt
Copy link
Collaborator

@ryanhoangt ryanhoangt commented Feb 14, 2025

Description

This PR is to:

  • Use binaryornot to perform mimetype validation.

Related Issue

Fix #68

@ryanhoangt ryanhoangt requested a review from xingyaoww February 14, 2025 06:50
@ryanhoangt ryanhoangt marked this pull request as draft February 14, 2025 06:53
@ryanhoangt ryanhoangt marked this pull request as ready for review February 14, 2025 07:26
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably fine?

@xingyaoww
Copy link
Collaborator

@ryanhoangt can you also start a PR in OpenHands repo to use the latest release from this PR?

@ryanhoangt
Copy link
Collaborator Author

Yeah it should be fine, let me open a PR in the OpenHands repo.

@ryanhoangt ryanhoangt merged commit 2ccf3d8 into main Feb 14, 2025
10 checks passed
@ryanhoangt ryanhoangt deleted the fix-mimetype-check branch February 14, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit SQL files
3 participants