added css pro-tips for ('margins') #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorresjDev
suggested changes
Dec 1, 2023
|
|
||
| ```css | ||
| :empty { | ||
| display: none; | ||
| } | ||
| ``` | ||
|
|
||
| ### Use `margin-inline` to add margin to both right and left of an html element,moreover when you want to set margin to top and bottom with same value use the shorthand `margin-block` |
There was a problem hiding this comment.
lines 605 through 615 should be the only lines being included your pr is modifying a lot of lines please adjust this and resubmit
There was a problem hiding this comment.
cause of changes could be auto format setup in your IDE I'd start their
Removed Unnecessary lines as requested
|
Done As Requested!
…On Fri, 1 Dec 2023 at 06:32, Jesus Torres ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Only lines that should be changed / included should be for your margin CSS
work don't change any prior existing code please
------------------------------
In README.md
<#179 (comment)>
:
>
```css
:empty {
display: none;
}
```
+### Use `margin-inline` to add margin to both right and left of an html element,moreover when you want to set margin to top and bottom with same value use the shorthand `margin-block`
lines 605 through 615 should be the only lines being included your pr is
modifying a lot of lines please adjust this and resubmit
------------------------------
In README.md
<#179 (comment)>
:
>
```css
:empty {
display: none;
}
```
+### Use `margin-inline` to add margin to both right and left of an html element,moreover when you want to set margin to top and bottom with same value use the shorthand `margin-block`
cause of changes could be auto format setup in your IDE I'd start their
—
Reply to this email directly, view it on GitHub
<#179 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXO3HMVQPCKU4ZZC2YBBZGTYHFTW7AVCNFSM6AAAAAA2N4BFBWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJZGA2DMNRTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
TorresjDev
approved these changes
Dec 1, 2023
TorresjDev
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.