Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autotitle for conversations #511

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ceicke
Copy link
Contributor

@ceicke ceicke commented Sep 23, 2024

Fix autotilte for conversations for OpenAI and Anthropic

Fix autotilte for conversations for OpenAI and Anthropic
@krschacht
Copy link
Contributor

Thanks for tackling this! The change looks good so I’ll click merge now and I’ll do some more testing of this in production.

It’s weird that this broke because I distinctly remember confirming that Anthropic & Claude worked without the json directive. It’s supposed to be optional for both those models, it just helps the models more accurately return json. But I fully believe that commenting that out could be the source of the bug and adding this conditional is the safer path. I appreciate you tracking this down.

@krschacht krschacht merged commit caf0552 into AllYourBot:main Sep 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants