Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate pdm.lock in github action #26

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

pgarrison
Copy link
Collaborator

@pgarrison pgarrison commented Nov 1, 2024

Issue

Developers of this repo must be diligent to ensure that the following always stay in sync:

  • pyproject.toml
  • pdm.lock
  • requirements1.txt
  • requirements2.txt

This cannot be easily automated because github actions runners don't have CUDA (necessary to build the environment), but pyproject.toml and pdm.lock can be automatically validated.

Testing

The check runs below. It should pass and show that it ran pdm lock --check in the job output

Copy link
Collaborator

@ritvikvasan ritvikvasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pgarrison pgarrison merged commit e18d537 into main Nov 6, 2024
1 check passed
@pgarrison pgarrison deleted the automate-pdm-lock-validation branch November 6, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants