Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/first-pass-cells-along-pcs #12

Merged
merged 8 commits into from
Aug 4, 2020
Merged

Conversation

donovanr
Copy link
Contributor

@donovanr donovanr commented Aug 4, 2020

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [feature/first-pass-cells-along-pcs #12], adds tiff file format support
  • Provide context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@donovanr
Copy link
Contributor Author

donovanr commented Aug 4, 2020

getting flake8 errors that black isn't fixing -- should setup.cfg be updated so that black and flake8 agree on formatting?

cvapipe/steps/pca_path_cells/pca_path_cells.py:34:89: E501 line too long (125 > 88 characters)
cvapipe/steps/pca_path_cells/pca_path_cells.py:54:89: E501 line too long (89 > 88 characters)
cvapipe/steps/pca_path_cells/pca_path_cells.py:72:89: E501 line too long (140 > 88 characters)
cvapipe/steps/pca_path_cells/pca_path_cells.py:92:89: E501 line too long (92 > 88 characters)
cvapipe/steps/pca_path_cells/utils.py:27:1: W293 blank line contains whitespace
cvapipe/steps/pca_path_cells/utils.py:35:86: E231 missing whitespace after ','
cvapipe/steps/pca_path_cells/.ipynb_checkpoints/pca_path_cells-checkpoint.py:34:89: E501 line too long (125 > 88 characters)
cvapipe/steps/pca_path_cells/.ipynb_checkpoints/pca_path_cells-checkpoint.py:54:89: E501 line too long (89 > 88 characters)
cvapipe/steps/pca_path_cells/.ipynb_checkpoints/pca_path_cells-checkpoint.py:72:89: E501 line too long (140 > 88 characters)
cvapipe/steps/pca_path_cells/.ipynb_checkpoints/pca_path_cells-checkpoint.py:92:89: E501 line too long (92 > 88 characters)

Copy link
Contributor

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks on docs and styling.

cvapipe/steps/pca_path_cells/utils.py Show resolved Hide resolved
cvapipe/steps/pca_path_cells/pca_path_cells.py Outdated Show resolved Hide resolved
cvapipe/steps/pca_path_cells/pca_path_cells.py Outdated Show resolved Hide resolved
@evamaxfield
Copy link
Contributor

Potentially also add a test for this?

@evamaxfield evamaxfield changed the title first pass at step for finding cells along pcs feature/first-pass-cells-along-pcs Aug 4, 2020
@donovanr
Copy link
Contributor Author

donovanr commented Aug 4, 2020

added a test for correct output size. does not test correctness of distance algorthim

@donovanr donovanr merged commit 2c3995d into master Aug 4, 2020
@donovanr donovanr deleted the step/find_pca_axis_path_cells branch August 4, 2020 19:16
@ritvikvasan ritvikvasan mentioned this pull request Sep 22, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants