Added generic functions for context management #540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AllenDang @gucio321 I saw #517 and since I've been using generics a lot recently, I figured I'd try my hand at making the changes.
The
GetState
andSetState
functions still exist on thecontext
struct for backwards compatibility, but there are now generic versions of them.I've also updated the "internal" code to use the generic version instead.
I've kept the assert still for
GetState
to catch/prevent any mixing up of types.The "reason" behind
[T any, genericDisposable[T]]
is explained hereAlthough I'm using it to directly call
Dispose
, it helps enforce the Disposable interface and it's also needed to have the return type as a pointer of the generic type.Feel free to make any changes that you see fit.