Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mainthread: lock main os threa on Windows #887

Merged
merged 1 commit into from
Oct 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions mainthread_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,21 @@

package giu

// TODO: I have no working mainthread library for windows.
import "runtime"

// according to:
// https://github.com/AllenDang/giu/issues/881
// this init solves some windows problems.
// However I'm not sure about implications of this. Will turn out later.
func init() {
runtime.LockOSThread()
}

// I have no working mainthread library for windows.
// - this one for macOS crashes app immediately
// - this for linux (and everything else) freezes after a few seconds
//
// With no mianthread support this at least runs sometimes. Just keep your giu calls in one thread and everything should work.
//
// this seems to solve an issue: https://github.com/AllenDang/giu/issues/881
func mainthreadCallPlatform(c func()) {
c()
}
Loading