scroll bars

[jmc420]

Hi

I noticed an issue with the scroll bars.

The markup generated by react-bootstrap-table looks like this:

the css rule table-container has overflow:auto which should switch on the scroll bars when the table overflows.

However this does not work because there is no height defined for react-bs-container:

http://stackoverflow.com/questions/17295219/overflow-scroll-css-is-not-working-in-the-div

The scroll bar does appear if one defines a css rule for react-bs-container like this:

.react-bs-container {
height:100%;
}

However the height of the scroll bar is wrong because table-container has a height of 100% - if it is reduced to 90% then it is about correct.

Can you add a height to react-bs-container and adjust the height of table-container?

James

[AllenFang]

@jmc420, thanks this issue report, it's a enhancement got height of table, however, I've planed to design the new DOM structure of react-bootstrap-table, so I think this issue will be solved in that patch 👍

[DexterHaslem]

I know you are busy but do you have a rough timeline you will try new DOM structure? Currently trying to stack two tables in any react parents is quite broken so I look forward to it. I tried many other react tables & grids and they were all very disappointing compared to yours

[AllenFang]

@DexterHaslem, sorry for a long time to wait, I've solve all the issues about unalign and table in tabs problem. Currently, I'm test the capability on different browser currently, I am sure it will be released in these day. sorry

[AllenFang]

Dear all, v2.0.0 has been released, you can check #331 for more detail explanation and I'll close this issues, if problem still remain, please tell me on #331 or open an issue

[dk4210]

This solved it for me

.react-bs-table-container {
height:100%;
}

.react-bs-container-body {
max-height: 230px;
overflow-y: scroll;
}