Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll bars #254

Closed
jmc420 opened this issue Feb 2, 2016 · 5 comments
Closed

scroll bars #254

jmc420 opened this issue Feb 2, 2016 · 5 comments

Comments

@jmc420
Copy link

jmc420 commented Feb 2, 2016

Hi

I noticed an issue with the scroll bars.

The markup generated by react-bootstrap-table looks like this:

the css rule table-container has overflow:auto which should switch on the scroll bars when the table overflows.

However this does not work because there is no height defined for react-bs-container:

http://stackoverflow.com/questions/17295219/overflow-scroll-css-is-not-working-in-the-div

The scroll bar does appear if one defines a css rule for react-bs-container like this:

.react-bs-container {
height:100%;
}

However the height of the scroll bar is wrong because table-container has a height of 100% - if it is reduced to 90% then it is about correct.

Can you add a height to react-bs-container and adjust the height of table-container?

James

@AllenFang
Copy link
Owner

@jmc420, thanks this issue report, it's a enhancement got height of table, however, I've planed to design the new DOM structure of react-bootstrap-table, so I think this issue will be solved in that patch 👍

@DexterHaslem
Copy link
Contributor

I know you are busy but do you have a rough timeline you will try new DOM structure? Currently trying to stack two tables in any react parents is quite broken so I look forward to it. I tried many other react tables & grids and they were all very disappointing compared to yours

AllenFang added a commit that referenced this issue Mar 13, 2016
@AllenFang
Copy link
Owner

@DexterHaslem, sorry for a long time to wait, I've solve all the issues about unalign and table in tabs problem. Currently, I'm test the capability on different browser currently, I am sure it will be released in these day. sorry

@AllenFang
Copy link
Owner

Dear all, v2.0.0 has been released, you can check #331 for more detail explanation and I'll close this issues, if problem still remain, please tell me on #331 or open an issue

@jmc420 jmc420 mentioned this issue Oct 29, 2016
@dk4210
Copy link

dk4210 commented Jan 31, 2018

This solved it for me

.react-bs-table-container {
height:100%;
}

.react-bs-container-body {
max-height: 230px;
overflow-y: scroll;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants