Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-bootstrap-table.css #791

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Update react-bootstrap-table.css #791

merged 1 commit into from
Nov 2, 2016

Conversation

konekoya
Copy link
Contributor

  1. Remove unnecessary px unit after value 0.
  2. Some minor tweaks for code consistency.

1. Remove unnecessary px unit after value 0.
2. Some minor tweaks for code consistency
Copy link
Owner

@AllenFang AllenFang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllenFang
Copy link
Owner

Thanks you :)

@konekoya
Copy link
Contributor Author

No problem! wanted to help but just not sure where to start.. Let me know if there's anything that I can help with.

@AllenFang
Copy link
Owner

@konekoya, thanks :)

You can run the example by npm start and pick up a basic example to trace the code, I think it's a first step to figure out react-bootstrap-table. BTW, if you know how to use it, maybe you can just find the render function in BootstrapTable, its a good point to start up.

Anyway, you know I'm very not familiar with css... so if you have any idea or example to implement a native bootstrap table with vertical and horizontal scroll ability, I'll very appreciated for that.

There're too many unalign issue and the root cause maybe is that I use two separate table to construct this table component so that I need to give more effort to make this two table align. In my opinion, if I can achieve the vertical and horizontal scroll problem with css and little js in single table structure, these unalign issues I mentioned above will disappear absoulately

@konekoya
Copy link
Contributor Author

konekoya commented Oct 27, 2016

@AllenFang Thanks for the tips on how to get stated with it! In fact, I have used it in one of my projects. It's easy to pick up and integrate with React based projects. I will try to run the examples and gain a deeper understanding of it.

For the table scrollbar issue. I think I might able to come up with some solutions with pure CSS/Bootstrap. But I would like to discuss with you in person on 11/19 during your short visit in Hsinchu. Just wanted to ensure that I understand your problem correctly. Plus lots of React questions that have bothered me for quite a while.

@AllenFang
Copy link
Owner

But I would like to discuss with you in person on 11/19 during your short visit in Hsinchu.

ok 👍

@konekoya
Copy link
Contributor Author

Great! See you then.

@AllenFang AllenFang merged commit 32b9504 into AllenFang:master Nov 2, 2016
@AllenFang
Copy link
Owner

Merged on v2.5.7. Thanks your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants