-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-bootstrap-table.css #791
Conversation
konekoya
commented
Oct 25, 2016
- Remove unnecessary px unit after value 0.
- Some minor tweaks for code consistency.
1. Remove unnecessary px unit after value 0. 2. Some minor tweaks for code consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks you :) |
No problem! wanted to help but just not sure where to start.. Let me know if there's anything that I can help with. |
@konekoya, thanks :) You can run the example by Anyway, you know I'm very not familiar with css... so if you have any idea or example to implement a native bootstrap table with vertical and horizontal scroll ability, I'll very appreciated for that. There're too many unalign issue and the root cause maybe is that I use two separate table to construct this table component so that I need to give more effort to make this two table align. In my opinion, if I can achieve the vertical and horizontal scroll problem with css and little js in single table structure, these unalign issues I mentioned above will disappear absoulately |
@AllenFang Thanks for the tips on how to get stated with it! In fact, I have used it in one of my projects. It's easy to pick up and integrate with React based projects. I will try to run the examples and gain a deeper understanding of it. For the table scrollbar issue. I think I might able to come up with some solutions with pure CSS/Bootstrap. But I would like to discuss with you in person on 11/19 during your short visit in Hsinchu. Just wanted to ensure that I understand your problem correctly. Plus lots of React questions that have bothered me for quite a while. |
ok 👍 |
Great! See you then. |
Merged on |