Fixed sorting bug for multi column sort #996
Conversation
There was a bug in multi column sort where the orders and sort fields would be reversed on table redraws without the user changing the sort info. This was because array.reverse() was used which changes the underlying array. Applying slice().reverse() first makes a copy of the original array and then returns the reverse of it, leaving the original arrays in a correct state.
|
hello @varak69, thank your contribution, I'll review it as soon as possible, btw, is #973 (comment) the issue you try to solve? |
|
Hi @AllenFang I took a look at that issue and commented as to why it isn't working. Just a spelling error. This fix is for another issue which hasn't been logged but I came across it in our app. We had a table which was being unnecessarily redrawn on mouse enter/leave. Each time it was redrawn the order of the sort fields changed without them being changed by the user. I'll see if I can make a codepen for it. |
|
thanks for quickly response :) it's awesome that you found the root cause for that issue, just a wrong spell.. 👍 |
|
Here's a codepen: As you can see, the sort order isn't changed anywhere in the codepen yet when the component rerenders (just move the mouse over it multiple times), the sort field and sort order array are reversed each time. |
|
Released on |
|
Thank you! :) |
There was a bug in multi column sort where the orders and sort fields would be reversed on table redraws without the user changing the sort info. This was because array.reverse() was used which changes the underlying array. Applying slice().reverse() first makes a copy of the original array and then returns the reverse of it, leaving the original arrays in a correct state.