Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vbn quality metrics tutorial #2528

Merged

Conversation

corbennett
Copy link
Contributor

Overview:

This PR adds a note in the first markdown cell of the VBN quality metrics tutorial to warn users that the VBN SDK returns all units by default, without applying filters as was done with VCN. It also fixes several typos in subsequent markdown cells.

Type of Fix:

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • [ x] Documentation Change

Solution:

Edited the text in several markdown cells.

Changes:

-added note at top of notebook
-deleted misleading sentence about raw data being available
-fixed 2 text typos

Validation:

All edited cells run as expected.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2022

CLA assistant check
All committers have signed the CLA.

@aamster aamster self-requested a review August 30, 2022 22:55
@aamster aamster merged commit 56354b1 into AllenInstitute:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants