Vco eye tracking #2639
Merged
Vco eye tracking #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
approved these changes
Dec 23, 2022
|
|
||
| Parameters | ||
| ---------- | ||
| ophys_experiment_id |
There was a problem hiding this comment.
I assume you confirmed that the ids on the files are experiment_ids and not session_ids as we previously thought?
There was a problem hiding this comment.
They are experiment ids. One issue is that there are ~800 eye tracking files, but 2800 ophys experiments in the VCO release, so about 2000 experiments without eye tracking. I don't know if this was intentional. I will ask.
|
|
||
| Parameters | ||
| ---------- | ||
| ophys_experiment_id |
There was a problem hiding this comment.
Surrounding code did not use types, so I didn't either. My argument is that it makes it easier to read if adjacent code is stylistically similar. I guess the counterargument would be that 2 wrongs don't make a right.
allensdk/brain_observatory/data_release_utils/metadata_utils/utils.py
Outdated
Show resolved
Hide resolved
scripts/brain_observatory/deploy_visual_coding_ophys_eye_tracking.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2608
Tested manually that it works as expected