Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vbn lfp behavior tutorials #2640

Merged

Conversation

corbennett
Copy link
Contributor

Overview:

We recently released LFP and behavior-only data for Visual Behavior Neuropixels. This PR adds two tutorials to show users how to take advantage of this new data. I've also updated the docs page to include links to these notebooks (though this should be tested since this is my first time adding these).

Type of Fix:

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • [ x] Documentation Change

Changes:

  • added visual_behavior_neuropixels_LFP_analysis.ipynb: tutorial demonstrating how to access/analyze LFP data
  • added visual_behavior_neuropixels_analyzing_behavior_only_data.ipynb: tutorial demonstrating how to access/analyze behavior-only sessions
  • edited visual_behavior_neuropixels.rst to include links to the new notebooks

Validation:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Corbett Bennett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -0,0 +1,2481 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use a seeded random number generator here instead? This way the notebook execution will be consistent from run to run. https://numpy.org/doc/stable/reference/random/generator.html


Reply via ReviewNB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add some more info, we added a workflow to run notebooks when they get merged into the main branch, so that we can make sure it runs and also update it with the latest code. The notebook will change without a seed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok just added the seed before calling random.choice. Is this what you meant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good.

Copy link
Contributor

@aamster aamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Note to team pika: due to the notebook runner workflow, we'll have to parameterize the path to the manifest since the dummy path will crash. We'll have to make this change once this is merged.

@aamster aamster merged commit 005d3f4 into AllenInstitute:rc/2.15.0 Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants