ticket/PSB-24: Modify Age data_object to calculate mouse age at the date of aquisition of session. #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
force-pushed
the
ticket/PSB-24/dev
branch
2 times, most recently
from
c929ce3
to
93f3402
Compare
mikejhuang
reviewed
Jan 21, 2023
| def _check_timezone(cls, input_date: datetime) -> datetime: | ||
| if input_date.tzinfo is None: | ||
| # Add UTC tzinfo if not already set | ||
| input_date = pytz.utc.localize(input_date) |
There was a problem hiding this comment.
Is this done because it's assumed that date_of_acquisition is localized (PST?) ?
There was a problem hiding this comment.
Yes, matching the logic in the DateOfAcquiisition object here.
There was a problem hiding this comment.
I see, it localizes it to UTC which makes more sense to me.
mikejhuang
approved these changes
Jan 21, 2023
morriscb
force-pushed
the
ticket/PSB-24/dev
branch
from
93f3402
to
c8c8b8e
Compare
morriscb
force-pushed
the
ticket/PSB-24/dev
branch
from
5847fd5
to
21f55c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.