-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rc/2.16.0 #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify Stimfile to add additional properties. Modify BS UUID from stimulus file method. Add timezone to behavior metdata table cloud api. Add datetime conversion. Change age_in_days to pandas.Int64 type. Fix imaging_plane_group typing. Input dummy time stamps for r and RMSE values. Enforce typing on image_plane_group_count. Add new Unittests Update existing unittests Add optional to stim file return. Add new NWBWiter subclass. Modify ophys nwb creation script. Add metadata table schema file. Add update function for targeted_imaging_depth Add new _update_session functino to nwb writer. Remove old writers and tests. Move base behavior schema
Add parser unittests. Move add_experience_level from vbn_2022
Add VBO project codes and stimulus_block maps Add project code to stimulus file processing. Add gray screen block at start of stimulus. Update write_nwb schemas for dir output.
Add dummy trials object to testing. Update presentations.pkl file. Update docstrings. update test pickle data.
Update tested python versions to 3.8 - 3.10
This reverts commit d637703.
Modify output path Add full output dict. Properly use output schema. Add behavior_session and ophys_experiment prefix.
LEFT JOIN on container due to potential missing container
Make metadata writer more closely follow VBN writer. metadata writer uses and shares argschema with VBN writer. Change writer to get paths from disk not LIMS. Enforce Int64 typing when loading metadata from S3 cache. Move check for already written metadata files to schema.
isort+black test_receptive_field_mapping
Add link to issue with histogram.
Add _enforce typing function to enforce int types. remove fillna from image_plane_count Rename add_experince_level. Generalize experience_level calculation for edge cases. Add experience_level to all tables. Rename targeted_areas -> num_targeted_structures Fix typo in num_depths_per_area Enforce metadata table column order
Add column ordering and integer type fixing. Generalize ordering and typing across metadata and other tables. Change null values to -99 and use int type. Better enforce typing for calculated values in stimulus_processing. Update stimulus_block_name to properly handle training sessions. Fix bug in trials_id being added for grey screen stimulus Add blank stimulus to start of stimulus presentations where needed. Don't add trials_id if stimulus_block isn't there.
Revert compatiblity in anticipation of merge.
Generalize compare_sessions input name. Allow temp compatiblity with test release (manifest min=0.0.0).
Add file attribute for download. Hook up natural movie into cache. Add natural movie processing. Add natural movie test. Add get_file_attributes method. Change return type.
Add project codes to stim processing. Switch trials_id calculation to not require stimulus_block. Remove x,y,heigh,width Update change log Update cells table. Clean up and format cache warning message. Update change log with counts and comment suggestions. Remove incorrect information. Update numbers and image in visual behavior documentation. Change bucket location to test rc notebooks against new data (temporary for testing).
Improve metadata symmetry of typing between S3 load and LIMS. Add column order to lims.
Clean up language.
Update where natural movie is stored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates and compatibility for the 2023 VBO update