Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticket/PSB-257: Investigate AllenSDK test failure for python3.9 #2729

Merged
merged 1 commit into from
Oct 25, 2023
Merged

ticket/PSB-257: Investigate AllenSDK test failure for python3.9 #2729

merged 1 commit into from
Oct 25, 2023

Conversation

morriscb
Copy link
Contributor

Explicitly set xarray coordinates.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@morriscb morriscb changed the base branch from master to rc/2.16.0 October 25, 2023 19:25
@morriscb morriscb marked this pull request as ready for review October 25, 2023 19:25
@mikejhuang
Copy link
Contributor

mikejhuang commented Oct 25, 2023 •
edited
Loading

Can you rerun the failed Python 3.9 tests on bamboo before merging into rc/2.16.0?

If so, please link to the tests here.
If not, how did you verify this resolved the issues?

@morriscb
Copy link
Contributor Author

morriscb commented Oct 25, 2023 •
edited
Loading

Ran the test with python3.9 in a fresh conda environment on Linux. Was able to reproduce the issue from the bamboo test. Once I applied the fix shown here, the tests passed. The code change on this ticket produces the same output data, it is just more explicit in the manipulation of the xarray.

The tests on bamboo are unfortunately only set up for master and rc branches. I quickly checked again just now and there wasn't an obvious way to trigger the test on a specific branch.

@morriscb morriscb merged commit fe87c87 into rc/2.16.0 Oct 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikejhuang mikejhuang mikejhuang approved these changes

@aamster aamster Awaiting requested review from aamster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morriscb @mikejhuang