ticket/PSB-260: Bug fix to VBN #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
morriscb
force-pushed
the
ticket/PSB-260/dev
branch
from
46b1a60
to
44809f2
Compare
morriscb
force-pushed
the
ticket/PSB-260/dev
branch
from
a08c5c4
to
0c74c3c
Compare
aamster
approved these changes
Nov 16, 2023
| @@ -12,48 +12,67 @@ class BehaviorSessionMetadataSchema(RaisingSchema): | |||
| age_in_days = Int(required=True, description="Subject age") | |||
| behavior_session_id = Int( | |||
| required=True, | |||
| allow_none=True, | |||
There was a problem hiding this comment.
If allow_none is True, then required should be False
| if first_row["omitted"]: | ||
| input_df = input_df.drop(first_row.name, axis=0) | ||
| else: | ||
| first_row = input_df.iloc[0] |
There was a problem hiding this comment.
first_row = input_df.iloc[0]
if not pd.isna(first_row["omitted"]):
if first_row["omitted"]:
input_df = input_df.drop(first_row.name, axis=0)
this needs to be modularized and not repeated
| """ | ||
| if column_name not in bs_row.index: | ||
| warn(f"Warning, {column_name} not in metadata table. Unless this " | ||
| "has been added it to skip_metadata_key or " |
|
|
||
| return behavior_session_metadata | ||
|
|
||
| def _retrieve_column(self, bs_row: pd.Series, column_name: str): |
There was a problem hiding this comment.
looks like this is retrieving a value from a series, the name implies it's retrieving a column from a dataframe
Warn that the column is missing. Add include_experiment_description to write nwb.
morriscb
force-pushed
the
ticket/PSB-260/dev
branch
from
8bb542a
to
9e79b44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand logic to drop an omitted stimulus as first to the replay block of VBN.
Added logic to allow for VBN data to run through behavior nwb creation. Missing column not in VBN behavior_sessions metadata table.