calcium refactoring #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuromusic
force-pushed
the
feature/refactor_calcium
branch
from
c16dd98
to
47c3423
Compare
added 3 commits
November 22, 2017 22:06
nicain
reviewed
Dec 1, 2017
| def robust_std(self, x): | ||
| ''' | ||
| Robust estimate of std | ||
| def _robust_std(self, x): |
There was a problem hiding this comment.
Why making this more protected? Can it be moved into a utility module, so that other parts of the code base can use it?
There was a problem hiding this comment.
my first motivation was to hide the class from the documentation. it's not intended AFAIK to be used elsewhere.
agreed it should probably get pulled out into a separate function to improve modularity & testing, even if not into a separate module yet.
nicain
approved these changes
Dec 1, 2017
|
thanks @nicain !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR addresses #48
todo: