Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent approach to storing coordinates #68

Closed
arsenius7 opened this issue Nov 28, 2018 · 2 comments
Closed

Consistent approach to storing coordinates #68

arsenius7 opened this issue Nov 28, 2018 · 2 comments
Labels
edges Data model, H5 and CSV files for edges nodes Data model, H5 and CSV files for nodes

Comments

@arsenius7
Copy link
Contributor

According to the spec, cell positions are now stored as x, y, z 1-D attributes; while synapse positions are stored as 2-D attributes (e.g., afferent_center_position).

Ideally we should be consistent here.
Imho, storing positions in 2-D attributes makes sense since we usually need all the coordinates; but we need to recall why we decided to go with x, y, z for cell positions recently. :)

@arsenius7 arsenius7 added nodes Data model, H5 and CSV files for nodes edges Data model, H5 and CSV files for edges labels Nov 28, 2018
@hernando
Copy link
Collaborator

Nobody seems to recall and after having decided to represent orientation with quaternions, which will probably be stored as a 2-D array with 4 columns, it makes sense to reconsider storing positions in a single dataset again.

@arsenius7
Copy link
Contributor Author

For the moment we decided to get away with 1-D attributes only; and modified the spec for synapse positions accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edges Data model, H5 and CSV files for edges nodes Data model, H5 and CSV files for nodes
Projects
None yet
Development

No branches or pull requests

2 participants