Specify how to represent node types when target_simulator is "NEST" or "PyNN"
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markovg
reviewed
Sep 12, 2018
hernando
reviewed
Oct 15, 2018
docs/SONATA_DEVELOPER_GUIDE.md
Outdated
| @@ -557,6 +568,8 @@ The namespace of parameters depends on model_type, and are defined as follows. | |||
|
|
|||
| **For point_process models**, it is the namespace of the point_process/artificial cell mechanism. | |||
|
|
|||
| **For point_neuron models**, it is the namespace of the neuron parameter dictionary. | |||
There was a problem hiding this comment.
I was doing some editing and I thought that keeping this new entry and removing "For point_process models" would be enough, but one line up (which doesn't appear in the diff) there's text for point_soma models. Where does this point_soma model type come form @markovg? It hasn't been listed before.
There was a problem hiding this comment.
I'd like to unblock and merge this review, @markovg, is there anybody that I can ask for clarifications about where does point_soma come from and whether we can remove it.
hernando
force-pushed
the
NEST-PyNN
branch
3 times, most recently
from
82b56e8 to
a6dccff
Compare
kaeldai
approved these changes
Oct 17, 2018
|
I'm not going to merge this yet. There's still an inconsistency in the text that I'd like to be addressed before doing so. |
added 2 commits
November 27, 2018 11:39
This table has becomes confusing if we add non NEURON specific information for point_neuron models. It also doesn't add anything that is not already said above.
hernando
force-pushed
the
NEST-PyNN
branch
2 times, most recently
from
e63d03d to
6d77810
Compare
added 2 commits
November 27, 2018 12:40
…omas. It could be confusing and it doesn't add information as the area of a sphere and the revolution surface of a cylinder inscribing the sphere are equal.
wvangeit
approved these changes
Nov 27, 2018
pgleeson
added a commit
to pgleeson/sonata
that referenced
this pull request
Nov 29, 2018
* 'master' of github.com:AllenInstitute/sonata: updating setup metadata for pypi Fixing so that all examples use model_name instead of pop_name Updating pysonata code Specify how to represent node types when `target_simulator` is "NEST" or "PyNN" (AllenInstitute#33)
pgleeson
added a commit
to pgleeson/sonata
that referenced
this pull request
Nov 29, 2018
* 'master' of github.com:AllenInstitute/sonata: updating setup metadata for pypi Fixing so that all examples use model_name instead of pop_name Updating pysonata code Specify how to represent node types when `target_simulator` is "NEST" or "PyNN" (AllenInstitute#33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose a minor change to the spec to make clear how to specify point neuron models for simulators other than NEURON (for which NMODL artificial cells are not usable).