Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove XValue unit value combinations #88

Merged

Conversation

dbirman
Copy link
Member

@dbirman dbirman commented Oct 4, 2024

BREAKING CHANGE: removes all XValue classes

The intention is to replace these with validators to check that units are included with values

There are only a few places these are being used:
https://github.com/AllenNeuralDynamics/SPIM-UI-Launch/blob/342d357be6aec3798aefe3b6d6ed4d1397678d57/exaSPIM/exaSPIM-UI-Luanch.py#L5
https://github.com/AllenNeuralDynamics/SPIM-UI-Launch/blob/342d357be6aec3798aefe3b6d6ed4d1397678d57/iSPIM/iSPIM-UI-Launch.py#L5

and a few places in aind-data-schema although confusingly it's used in the tests but not in the actual schema?

BREAKING CHANGE: removes all XValue classes

The intention is to replace these with validators to check that units are included with values
@dbirman dbirman linked an issue Oct 4, 2024 that may be closed by this pull request
7 tasks
@dbirman dbirman changed the base branch from main to v1 October 16, 2024 17:46
@dbirman
Copy link
Member Author

dbirman commented Oct 16, 2024

Changed this to merge into a "v1" branch instead of main

@dbirman dbirman merged commit 1a7dab4 into v1 Oct 17, 2024
4 checks passed
@dbirman dbirman deleted the 86-deprecate-or-remove-if-unused-xvalue-classes-from-unitspy branch October 17, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate or remove (if unused) XValue classes from units.py
2 participants