Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy, pre-0.8.3 code #1016

Merged
merged 18 commits into from
Feb 12, 2022
Merged

Remove legacy, pre-0.8.3 code #1016

merged 18 commits into from
Feb 12, 2022

Commits on Feb 12, 2022

  1. allsky.sh: improvements 1 

    Stop the allsky service on fatal errors since the next execution of allsky will also fail, getting us into an infinite loop.
Exit with 100 on fatal errors for a future change where systemctl will not restart the service for error codes >= 100.
Add color to some error messages
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    4220bc9 View commit details
    Browse the repository at this point in the history

  2. allsky.sh: improvements 2 

    Handle exit codes 98 and 99 from the capture programs (which will be added via a separate PR).
Add initial code for trying to determine if the service is restarting, versus stopping.  On a restart we can display a message "Allsky software is restarting" and skip the "Allsky software is not running" message that appears when the service stops.  I'm pretty sure there's a way with systemctl that allows it to send a different signal on stop versus restart.  allsky.sh and the capture programs could then check which signal was sent.
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    2dbc536 View commit details
    Browse the repository at this point in the history

  3. allsky,sh: remove legacy code # 1 

    First pass at removing the legacy / compatibility code.
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    2691b7a View commit details
    Browse the repository at this point in the history

  4. config.sh.repo: remove compatibility code 

    Assume this file is used with version 0.8.3 or later, so remove the code that made it compatible with older releases.
Move the functionality of the scripts/filename.sh file here, since almost every time config.sh is sourced in, so is filename.sh.
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    131a538 View commit details
    Browse the repository at this point in the history

  5. config.sh.repo: prepare for update code 

    In preparation for an Allsky update script, add a variable that will tell the script when to stop looking for user-settable variables.
The script will use the new config.sh file but will copy the user's settings from the old config.sh to the new file, stopping at END_OF_USER_SETTINGS.
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    3c1a8aa View commit details
    Browse the repository at this point in the history

  6. config.sh.repo: remove unneeded keogram stuff 

    --rotate 0    is the default
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    19a4d53 View commit details
    Browse the repository at this point in the history

  7. allsky.sh: remove legacy code 

    Assume this version runs with 0.8.3 so there's no need for legacy code to handle CAMERA=auto or to check for obsolete variables.  This simplifies the code somewhat.
Remove duplicate check for reset_usb.
The functionality of scripts/filename.sh was moved to config/config.sh so no need to source in filename.sh
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    1097c08 View commit details
    Browse the repository at this point in the history

  8. copy_notification_image.sh: remove filename.sh

    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    af361ca View commit details
    Browse the repository at this point in the history

  9. endOfNight.sh: remove filename.sh

    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    42fc438 View commit details
    Browse the repository at this point in the history

  10. generateForDay.sh: remove filename.sh

    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    a830085 View commit details
    Browse the repository at this point in the history

  11. removeBadImages.sh: remove filename.sh

    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    15675fc View commit details
    Browse the repository at this point in the history

  12. saveImage.sh: remove filename.sh

    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    1404afa View commit details
    Browse the repository at this point in the history

  13. timelapse.sh: remove filename.sh 

    Also remove unneeded compatibility code
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    4 Configuration menu
    Copy the full SHA
    7fd6634 View commit details
    Browse the repository at this point in the history

  14. upload.sh: remove filename.sh

    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    7d43bb9 View commit details
    Browse the repository at this point in the history

  15. filename.sh: remove 

    Its functionality was moved to config.sh
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    2c1cc62 View commit details
    Browse the repository at this point in the history

  16. allsky.sh: add ending newline 

    to keep workflow checker happy
    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    c095e28 View commit details
    Browse the repository at this point in the history

  17. allsky.sh: add missing "fi"

    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    db30445 View commit details
    Browse the repository at this point in the history

  18. ftp-settings.sh.repo: remove legacy code

    @EricClaeys
    EricClaeys authored Feb 12, 2022
    Configuration menu
    Copy the full SHA
    ae9fc33 View commit details
    Browse the repository at this point in the history