Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay.json updates #2499

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Overlay.json updates #2499

merged 5 commits into from
Mar 27, 2023

Conversation

EricClaeys
Copy link
Collaborator

In the repo overlay*.json files:

  • Merge the DATE and TIME fields since users typically want both of them, and it's easier to deal with as one field.
  • Add CAMERA_TYPE and CAMERA_MODEL to the bottom left of the image.
  • Remove TEMPERATURE_C from RPi version.
  • Set the fall-back "overlay.json" file to be the ZWO version without TEMPERATURE_C.

@EricClaeys
overlay.json: updates
776932e 
* Combine DATE and TIME into one field - I suspect people will want those fields together.
* Remove TEMPERATURE_C - It won't work with RPi cameras which is around half the users.
* Start "id" at 0.
* Align all fields.
@EricClaeys
overlay-RPi.json: changes
cf04b8c 
* Combined DATE and TIME fields
* Added CAMERA_TYPE and CAMERA_MODEL
* Aligned fields
@EricClaeys
overlay-ZWO.json: same as overlay-RPi
dfed8c8 
Different font sizes and location since most ZWO cameras are smaller.
@EricClaeys
overlay.json: use ZWO for default
09eebfb
@EricClaeys
overlay-ZWO.json: add sensor temp
ccfb9f7
@EricClaeys EricClaeys merged commit e8d8562 into dev Mar 27, 2023
@EricClaeys EricClaeys deleted the overlay.json-updates branch March 27, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-developer Alex-developer Alex-developer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricClaeys @Alex-developer