-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for linefeed and carriage return #425
Merged
thomasjacquin
merged 29 commits into
AllskyTeam:master
from
EricClaeys:EricClaeys-carriage-return
Aug 15, 2021
Merged
Check for linefeed and carriage return #425
thomasjacquin
merged 29 commits into
AllskyTeam:master
from
EricClaeys:EricClaeys-carriage-return
Aug 15, 2021
Commits on Jul 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 94e425e - Browse repository at this point
Copy the full SHA 94e425eView commit details -
Implements notification images, reboots USB bus if camera isn't found, adds error checking.
Configuration menu - View commit details
-
Copy full SHA for a08f239 - Browse repository at this point
Copy the full SHA a08f239View commit details -
Implements notification images. Allows users to specify via config file if bad images should be removed. Removed duplicate code. Added return code checks.
Configuration menu - View commit details
-
Copy full SHA for 82f1d28 - Browse repository at this point
Copy the full SHA 82f1d28View commit details -
Added some error checking. Added COPY_TO_WEBSITE and RESIZE_UPLOADS options. Added lftp commands to upload temporary file name, then move to permanent name, to help avoid issues with slow upload speeds.
Configuration menu - View commit details
-
Copy full SHA for a6d8abf - Browse repository at this point
Copy the full SHA a6d8abfView commit details
Commits on Aug 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 998950d - Browse repository at this point
Copy the full SHA 998950dView commit details
Commits on Aug 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3ae07e8 - Browse repository at this point
Copy the full SHA 3ae07e8View commit details -
Implement notification images. Dark frame from "capture" is now called "dark.$EXTENSION" to distinguish from normal image. Used $IMG_PREFIX.
Configuration menu - View commit details
-
Copy full SHA for 1145558 - Browse repository at this point
Copy the full SHA 1145558View commit details -
Does error checking on "convert". Lets user know if they've set DARK_FRAME_SUBTRACTION on but have no darks.
Configuration menu - View commit details
-
Copy full SHA for 2829369 - Browse repository at this point
Copy the full SHA 2829369View commit details -
Saves "keogram" and "startrails" output in temp files rather than putting the 1000+ lines in the log file. Runs "removeBadImages" based on "$REMOVE_BAD_IMAGES" in config.sh. Only upload keogram and startrails if they were successfully created.
Configuration menu - View commit details
-
Copy full SHA for 8b7f315 - Browse repository at this point
Copy the full SHA 8b7f315View commit details -
Update endOfNight_additionalSteps.sh
Mention adding "$ME" to any messages. "$ME" is the command name, and is useful to have in the log file to know which command produced the output.
Configuration menu - View commit details
-
Copy full SHA for 12042de - Browse repository at this point
Copy the full SHA 12042deView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca5412b - Browse repository at this point
Copy the full SHA ca5412bView commit details -
Implemented $ME. Commented out line since endOfNight.sh prints a similar line. Removed unnecessary double quotes on lftp line to make it easier to read.
Configuration menu - View commit details
-
Copy full SHA for 4983636 - Browse repository at this point
Copy the full SHA 4983636View commit details -
Removed check for DARK_MODE since darkCapture.sh exits the script if DARK_MODE is on. Moved "identity" check to top; there's no need to do anything else if the image is corrupt. Perform error checking on "convert". Allow user to specify thumbnail size and resize size. Implement $IMG_PREFIX instead of hard-coding "liveview-". Removed unnecessary double quotes on lftp line to make it easier to read.
Configuration menu - View commit details
-
Copy full SHA for c8f8ebc - Browse repository at this point
Copy the full SHA c8f8ebcView commit details -
Removed check for DARK_MODE since darkCapture.sh exits the script if DARK_MODE is on. Moved "identity" check to top; there's no need to do anything else if the image is corrupt. Perform error checking on "convert". Allow user to specify thumbnail size and resize size. Implement $IMG_PREFIX instead of hard-coding "liveview-". Removed unnecessary double quotes on lftp line to make it easier to read. The final image name is always the same now, so it's no longer "image-processed.jpg" if dark subtract is on, and "image.jpg" if it's off. That was confusing.
Configuration menu - View commit details
-
Copy full SHA for d19202a - Browse repository at this point
Copy the full SHA d19202aView commit details -
Optionally also checks for too dark and too bright images, based on REMOVE_BAD_IMAGES_THRESHOLD_LOW and REMOVE_BAD_IMAGES_THRESHOLD_HIGH from config.sh. NOTE: I'm not sure how to do that check if "parallel" is used. Removes bad thumbnails in addition to bad images, and displays reason they are removed. Centralized redundant code for easier maintenance. Outputs a summary line.
Configuration menu - View commit details
-
Copy full SHA for cecbf31 - Browse repository at this point
Copy the full SHA cecbf31View commit details -
Allows timelapses to be created for images no in ~/allsky/images. For example, for observatory cameras. Save "ln -s" output to temp file rather than outputting 1000+ lines to log file. temp file is save so user can look at it, and a summary is output. Perform error checking. Decreased useless output from ffmpeg. lftp puts to a temp name, then renames it to the correct name. This is because timelapse files are large and if the web server tries to read the file as it's being uploaded, it will get an error.
Configuration menu - View commit details
-
Copy full SHA for 6bd2a68 - Browse repository at this point
Copy the full SHA 6bd2a68View commit details -
Implement $ME. Remove unneeded double quotes in lftp. Removed "-u $USER,$PASSWORD" since it's not needed.
Configuration menu - View commit details
-
Copy full SHA for 1a707fb - Browse repository at this point
Copy the full SHA 1a707fbView commit details -
Mention new settings and new names to existing settings. Note that many of the settings (now and prior to these changes) don't apply to Pi cameras; I didn't do anything about that. I'm assuming the will be version 0.8, so added summary of changes.
Configuration menu - View commit details
-
Copy full SHA for cbba45c - Browse repository at this point
Copy the full SHA cbba45cView commit details -
Keep prior log file to aid in debugging. Ability to reset the USB bus if the ZWO camera isn't found. Put settings in a bash array, so they can have spaces in them. Optionally display "notification" images. Checks if output is a tty (user invoked it manually) or not (service invoked it) - this is used by capture program to display appropriate log messages.
Configuration menu - View commit details
-
Copy full SHA for a273911 - Browse repository at this point
Copy the full SHA a273911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74f6356 - Browse repository at this point
Copy the full SHA 74f6356View commit details -
Configuration menu - View commit details
-
Copy full SHA for 149cf7b - Browse repository at this point
Copy the full SHA 149cf7bView commit details -
Add new settings. Changed names on others.
Configuration menu - View commit details
-
Copy full SHA for e321f5e - Browse repository at this point
Copy the full SHA e321f5eView commit details -
Added many of the changes from the ZWO capture.cpp file to keep both files in better sync. NOTE: I don't have an RPiHQ camera so was unable to test the new version. It compiles, however. NOTE: I suggest removing the unused code from capture.cpp (it's commented out). It makes the file harder to read.
Configuration menu - View commit details
-
Copy full SHA for fc044bc - Browse repository at this point
Copy the full SHA fc044bcView commit details
Commits on Aug 5, 2021
-
Lots of updates from Eric Claeys and Linda xxx Workaround for ZWO auto exposure bug (included in #ifdef USE_HISTOGRAM blocks - on my default). Improved exposure algorithm that decreases sensor temperature about 10 C. Better exposure transition between day and night when gain is different. Many new settings and many old ones changed names. The recently submitted allsky-portal knows about these changes. Lots of error checking. Optionally displays "notification" images, like "Taking darks". On user error, displays a message and waits for the user to fix it, rather than exiting, restarting, exiting, etc. Gracefully exits when service sends SIGTERM signal. Lots of comments and additional debugging code added (based on actual problems people had). Handles dark frames better.
Configuration menu - View commit details
-
Copy full SHA for f67fa12 - Browse repository at this point
Copy the full SHA f67fa12View commit details
Commits on Aug 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d0e862b - Browse repository at this point
Copy the full SHA d0e862bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc7ed64 - Browse repository at this point
Copy the full SHA fc7ed64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7657eee - Browse repository at this point
Copy the full SHA 7657eeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b302888 - Browse repository at this point
Copy the full SHA b302888View commit details
Commits on Aug 13, 2021
-
Check for linefeed and carriage return
Files created on Windows machines have linefeed AND carriage return marking the end of the line. This adds checking for carriage return.
Configuration menu - View commit details
-
Copy full SHA for 9d59abd - Browse repository at this point
Copy the full SHA 9d59abdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.