Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for linefeed and carriage return #425

Merged
merged 29 commits into from
Aug 15, 2021
Merged

Check for linefeed and carriage return #425

merged 29 commits into from
Aug 15, 2021

Commits on Jul 10, 2021

  1. Add files via upload

    EricClaeys authored Jul 10, 2021
    Configuration menu
    Copy the full SHA
    94e425e View commit details
    Browse the repository at this point in the history
  2. Add files via upload

    Implements notification images, reboots USB bus if camera isn't found, adds error checking.
    EricClaeys authored Jul 10, 2021
    Configuration menu
    Copy the full SHA
    a08f239 View commit details
    Browse the repository at this point in the history
  3. Add files via upload

    Implements notification images.  Allows users to specify via config file if bad images should be removed.  Removed duplicate code.  Added return code checks.
    EricClaeys authored Jul 10, 2021
    Configuration menu
    Copy the full SHA
    82f1d28 View commit details
    Browse the repository at this point in the history
  4. Add files via upload

    Added some error checking.  Added COPY_TO_WEBSITE and RESIZE_UPLOADS options.  Added lftp commands to upload temporary file name, then move to permanent name, to help avoid issues with slow upload speeds.
    EricClaeys authored Jul 10, 2021
    Configuration menu
    Copy the full SHA
    a6d8abf View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Configuration menu
    Copy the full SHA
    998950d View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Update copy_notification_image.sh

    Minor updates.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    3ae07e8 View commit details
    Browse the repository at this point in the history
  2. Update darkCapture.sh

    Implement notification images.
    Dark frame from "capture" is now called "dark.$EXTENSION" to distinguish from normal image.
    Used $IMG_PREFIX.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    1145558 View commit details
    Browse the repository at this point in the history
  3. Update darkSubtract.sh

    Does error checking on "convert".
    Lets user know if they've set DARK_FRAME_SUBTRACTION on but have no darks.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    2829369 View commit details
    Browse the repository at this point in the history
  4. Update endOfNight.sh

    Saves "keogram" and "startrails" output in temp files rather than putting the 1000+ lines in the log file.
    Runs "removeBadImages" based on "$REMOVE_BAD_IMAGES" in config.sh.
    Only upload keogram and startrails if they were successfully created.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    8b7f315 View commit details
    Browse the repository at this point in the history
  5. Update endOfNight_additionalSteps.sh

    Mention adding "$ME" to any messages.  "$ME" is the command name, and is useful to have in the log file to know which command produced the output.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    12042de View commit details
    Browse the repository at this point in the history
  6. Update generateForDay.sh

    Added $DATE and $DIR for readability.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    ca5412b View commit details
    Browse the repository at this point in the history
  7. Update postData.sh

    Implemented $ME.
    Commented out line since endOfNight.sh prints a similar line.
    Removed unnecessary double quotes on lftp line to make it easier to read.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    4983636 View commit details
    Browse the repository at this point in the history
  8. Update saveImageDay.sh

    Removed check for DARK_MODE since darkCapture.sh exits the script if DARK_MODE is on.
    Moved "identity" check to top; there's no need to do anything else if the image is corrupt.
    Perform error checking on "convert".
    Allow user to specify thumbnail size and resize size.
    Implement $IMG_PREFIX instead of hard-coding "liveview-".
    Removed unnecessary double quotes on lftp line to make it easier to read.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    c8f8ebc View commit details
    Browse the repository at this point in the history
  9. Update saveImageNight.sh

    Removed check for DARK_MODE since darkCapture.sh exits the script if DARK_MODE is on.
    Moved "identity" check to top; there's no need to do anything else if the image is corrupt.
    Perform error checking on "convert".
    Allow user to specify thumbnail size and resize size.
    Implement $IMG_PREFIX instead of hard-coding "liveview-".
    Removed unnecessary double quotes on lftp line to make it easier to read.
    The final image name is always the same now, so it's no longer "image-processed.jpg" if dark subtract is on, and "image.jpg" if it's off.  That was confusing.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    d19202a View commit details
    Browse the repository at this point in the history
  10. Update removeBadImages.sh

    Optionally also checks for too dark and too bright images, based on REMOVE_BAD_IMAGES_THRESHOLD_LOW and REMOVE_BAD_IMAGES_THRESHOLD_HIGH from config.sh.
    NOTE: I'm not sure how to do that check if "parallel" is used.
    Removes bad thumbnails in addition to bad images, and displays reason they are removed.
    Centralized redundant code for easier maintenance.
    Outputs a summary line.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    cecbf31 View commit details
    Browse the repository at this point in the history
  11. Update timelapse.sh

    Allows timelapses to be created for images no in ~/allsky/images.  For example, for observatory cameras.
    Save "ln -s" output to temp file rather than outputting 1000+ lines to log file.  temp file is save so user can look at it, and a summary is output.
    Perform error checking.
    Decreased useless output from ffmpeg.
    lftp puts to a temp name, then renames it to the correct name.  This is because timelapse files are large and if the web server tries to read the file as it's being uploaded, it will get an error.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    6bd2a68 View commit details
    Browse the repository at this point in the history
  12. Update uploadForDay.sh

    Implement $ME.
    Remove unneeded double quotes in lftp.
    Removed "-u $USER,$PASSWORD" since it's not needed.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    1a707fb View commit details
    Browse the repository at this point in the history
  13. Update README.md

    Mention new settings and new names to existing settings.
    Note that many of the settings (now and prior to these changes) don't apply to Pi cameras; I didn't do anything about that.
    
    I'm assuming the will be version 0.8, so added summary of changes.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    cbba45c View commit details
    Browse the repository at this point in the history
  14. Update allsky.sh

    Keep prior log file to aid in debugging.
    Ability to reset the USB bus if the ZWO camera isn't found.
    Put settings in a bash array, so they can have spaces in them.
    Optionally display "notification" images.
    Checks if output is a tty (user invoked it manually) or not (service invoked it) - this is used by capture program to display appropriate log messages.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    a273911 View commit details
    Browse the repository at this point in the history
  15. Update config.sh.repo

    Includes new variables.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    74f6356 View commit details
    Browse the repository at this point in the history
  16. Update settings_RPiHQ.json.repo

    Added new and renamed settings.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    149cf7b View commit details
    Browse the repository at this point in the history
  17. Update settings_ZWO.json.repo

    Add new settings.  Changed names on others.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    e321f5e View commit details
    Browse the repository at this point in the history
  18. Update capture_RPiHQ.cpp

    Added many of the changes from the ZWO capture.cpp file to keep both files in better sync.
    
    NOTE: I don't have an RPiHQ camera so was unable to test the new version.  It compiles, however.
    
    NOTE: I suggest removing the unused code from capture.cpp (it's commented out).  It makes the file harder to read.
    EricClaeys authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    fc044bc View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Update capture.cpp

    Lots of updates from Eric Claeys and Linda xxx
    Workaround for ZWO auto exposure bug (included in #ifdef USE_HISTOGRAM blocks - on my default).
    Improved exposure algorithm that decreases sensor temperature about 10 C.
    Better exposure transition between day and night when gain is different.
    Many new settings and many old ones changed names.  The recently submitted allsky-portal knows about these changes.
    Lots of error checking.
    Optionally displays "notification" images, like "Taking darks".
    On user error, displays a message and waits for the user to fix it, rather than exiting, restarting, exiting, etc.
    Gracefully exits when service sends SIGTERM signal.
    Lots of comments and additional debugging code added (based on actual problems people had).
    Handles dark frames better.
    EricClaeys authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    f67fa12 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. Configuration menu
    Copy the full SHA
    d0e862b View commit details
    Browse the repository at this point in the history
  2. Update capture.cpp

    EricClaeys committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    fc7ed64 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7657eee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b302888 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. Check for linefeed and carriage return

    Files created on Windows machines have linefeed AND carriage return marking the end of the line.  This adds checking for carriage return.
    EricClaeys authored Aug 13, 2021
    Configuration menu
    Copy the full SHA
    9d59abd View commit details
    Browse the repository at this point in the history