Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer tweaks #500

Merged
merged 6 commits into from
Sep 24, 2021
Merged

Conversation

linuxkidd
Copy link
Collaborator

  • Removed need to run script with sudo.
    • This fixes incorrect root user being applied to systemd and other locations.
  • Changed systemd install path to /etc since this is user provided, not system
  • Changed to use install commands instead of cp/chmod/chown dances
  • Changed to apt from apt-get for better user experience
  • Changed references to logname to $USER
  • Make copying of *.repo files conditional on non-existence of target.

@EricClaeys
Copy link
Collaborator

I also removed the RED around the Welcome message, since red indicates error.

Copy link
Collaborator

@EricClaeys EricClaeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thomasjacquin thomasjacquin merged commit 2864f9f into AllskyTeam:master Sep 24, 2021
@linuxkidd linuxkidd deleted the installer_tweaks branch September 24, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants