gui/install.sh: update sudoers with vcgencmd #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update /etc/sudoers.d/allsky if needed and possible. Added banner for updates. Move SCRIPTPATH up since it's needed higher in file now.
ckuethe
reviewed
Nov 12, 2021
vcgencmd is in a different location in Bullseye vs Buster
works with Buster or Bullseye
linuxkidd
reviewed
Nov 16, 2021
gui/install.sh
Outdated
| # Add entries to sudoers file if not already there. | ||
| # This is only needed for people who updated allsky-portal but didn't update allsky. | ||
| # Don't simply copy the "allsky" file to /etc/sudoers.d in case "allsky" isn't up to date. | ||
| grep --silent "vcgencmd" /etc/sudoers.d/allsky |
There was a problem hiding this comment.
Let's change this to grep -c (count matches) and capture the response. Then in the conditional, ensure the response is 2, otherwise we need to update the sudoers file.
There was a problem hiding this comment.
Oh, I just noticed we only add the /usr/bin path now, not the opt path...
So, we need to check here for the correct path instead of just the presence of vcgencmd.
linuxkidd
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update /etc/sudoers.d/allsky if needed and possible.
Added banner for updates.
Move SCRIPTPATH up since it's needed higher in file now.