Allow web install over prior version #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take into account that the user may already have the Allsky Website installed, so save it, then install the new version, and restore saved videos, keograms, and startrails as well as any associated thumbnails. Also restore configuration files. If the user is installing Allsky Website for the first time, set some configuration variables based on the Allsky configuration. The code dealing with configuration files was moved to a function "modify_configuration_variables" in case we want to call it on "--update".
Add an error check. Make error messages more consistent. Improve message after completion and include Wiki URL for new website users. Remove "set -x" left over from my testing.
|
@EricClaeys: I'm sorry but I can't review/test this. I haven't done anything with this part yet |
functions.php needs to know if it's on a Pi so it can check the "XX_ALLSKY_CONFIG_XX" placeholder and if not updated, warn the user. On remote servers we should NOT check the placeholder. The "XX_ON_PI_XX" placeholder is set "true" during installation on a Pi which tells functions.php it's running on a Pi. There is no longer a need to replace only the 1st instance of XX_ALLSKY_CONFIG_XX since there is now only one instance.
linuxkidd
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets users install updates to the Allsky website via
~/allsky/website/install.sh. It saves their timelapse, keograms, startrails, and configuration files, then restores them after the update.