Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github actions python version and support 3.8 #69

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Fix github actions python version and support 3.8 #69

merged 4 commits into from
Feb 27, 2024

Conversation

jja725
Copy link
Contributor

@jja725 jja725 commented Feb 27, 2024

No description provided.

@jja725 jja725 changed the base branch from main to dev February 27, 2024 21:43
@jja725 jja725 requested review from LuQQiu and ChunxuTang February 27, 2024 21:46
@LuQQiu LuQQiu changed the title Fix github actions python version Fix github actions python version and support 3.8 Feb 27, 2024
@LuQQiu
Copy link
Contributor

LuQQiu commented Feb 27, 2024

self = <alluxio.worker_ring.ConsistentHashProvider object at 0x7f5c36982a10>
worker = WorkerIdentity(version=1, identifier=b'O#\xe7\xa1\xa201\x8a\x91-\xbd\xf8\xf7\x8e\n\xed')
node_index = 0

def _hash_worker_identity(
    self, worker: WorkerIdentity, node_index: int
) -> int:
    # Hash the combined bytes
  hasher = mmh3.mmh3_32()

E AttributeError: module 'mmh3' has no attribute 'mmh3_32'

This is the error in Python 3.7

mmh3 says drop python 3.7 since the lifecycle is Python 3.7 end-of-life (EOL) is 2023-06-27 and Ray will drop the support with the following plan: Ray 2.7 will be the last version that supports Python 3.7. Ray 2.8 will no longer have Python 3.7 wheels for installation.

Leave the decision of supporting python 3.7 to future PRs

@LuQQiu
Copy link
Contributor

LuQQiu commented Feb 27, 2024

@jja725 PTAL, thanks!

@jja725 jja725 merged commit fff9872 into dev Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants